Skip to content

[8.x] Add new VendorTagPublished event #36458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 4, 2021
Merged

[8.x] Add new VendorTagPublished event #36458

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4cadadc
feature: add new VendorTagPublished event
ryangjchandler Mar 4, 2021
08b48c1
fix: only fire event when something was published
ryangjchandler Mar 4, 2021
390b609
refactor: fire event before erroring in console
ryangjchandler Mar 4, 2021
ddb1d02
revert: move event dispatch into else arm
ryangjchandler Mar 4, 2021
385f682
chore: update comment on $paths
ryangjchandler Mar 4, 2021
d3376b8
chore: publish to publishable
ryangjchandler Mar 4, 2021
8a25a0a
chore: add missing comment
ryangjchandler Mar 4, 2021
81d6847
Update VendorPublishCommand.php
taylorotwell Mar 4, 2021
8a7318d
Update VendorTagPublished.php
taylorotwell Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert: move event dispatch into else arm
  • Loading branch information
@ryangjchandler
ryangjchandler committed Mar 4, 2021
commit ddb1d024da7797f3dc9bce2dfb41440681f5cf54
4 changes: 2 additions & 2 deletions src/Illuminate/Foundation/Console/VendorPublishCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ protected function publishTag($tag)
$published = true;
}

$this->laravel['events']->dispatch(new VendorTagPublished($tag, $pathsToPublish));

if ($published === false) {
$this->error('Unable to locate publishable resources.');
} else {
$this->laravel['events']->dispatch(new VendorTagPublished($tag, $pathsToPublish));
}
}

Expand Down