Skip to content

[8.x] Add resource missing option #36562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[8.x] Add resource missing option #36562

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62925b6
Add resource missing option
zholzhas Mar 11, 2021
c887875
Add resource missing option
zholzhas Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add resource missing option
  • Loading branch information
@zholzhas
zholzhas committed Mar 11, 2021
commit c887875c23f393e3443b1fd2a8dd0c748e6f13ea
15 changes: 7 additions & 8 deletions src/Illuminate/Routing/ResourceRegistrar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ class ResourceRegistrar
*/
protected $resourceDefaults = ['index', 'create', 'store', 'show', 'edit', 'update', 'destroy'];

/**
* Actions that use model binding.
*
* @var string[]
*/
protected $modelBoundMethods = ['show', 'edit', 'update', 'destroy'];

/**
* The parameters set for this resource instance.
*
Expand Down Expand Up @@ -191,6 +184,8 @@ protected function addResourceIndex($name, $base, $controller, $options)
{
$uri = $this->getResourceUri($name);

unset($options['missing']);

$action = $this->getResourceAction($name, $controller, 'index', $options);

return $this->router->get($uri, $action);
Expand All @@ -209,6 +204,8 @@ protected function addResourceCreate($name, $base, $controller, $options)
{
$uri = $this->getResourceUri($name).'/'.static::$verbs['create'];

unset($options['missing']);

$action = $this->getResourceAction($name, $controller, 'create', $options);

return $this->router->get($uri, $action);
Expand All @@ -227,6 +224,8 @@ protected function addResourceStore($name, $base, $controller, $options)
{
$uri = $this->getResourceUri($name);

unset($options['missing']);

$action = $this->getResourceAction($name, $controller, 'store', $options);

return $this->router->post($uri, $action);
Expand Down Expand Up @@ -428,7 +427,7 @@ protected function getResourceAction($resource, $controller, $method, $options)
$action['where'] = $options['wheres'];
}

if (isset($options['missing']) && in_array($method, $this->modelBoundMethods)) {
if (isset($options['missing'])) {
$action['missing'] = $options['missing'];
}

Expand Down