Skip to content

[8.x] Use different config key for overriding temporary url host in AwsTemporaryUrl method #36612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021
Merged

[8.x] Use different config key for overriding temporary url host in AwsTemporaryUrl method #36612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36e5d1e
Use different config key for overriding temporary url host
jnoordsij Mar 16, 2021
2d2c813
Update FilesystemAdapter.php
taylorotwell Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use different config key for overriding temporary url host
  • Loading branch information
@jnoordsij
jnoordsij committed Mar 16, 2021
commit 36e5d1e03e4e8ce838da32a80706a4bd9b6532e5
2 changes: 1 addition & 1 deletion src/Illuminate/Filesystem/FilesystemAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ public function getAwsTemporaryUrl($adapter, $path, $expiration, $options)
// If an explicit base URL has been set on the disk configuration then we will use
// it as the base URL instead of the default path. This allows the developer to
// have full control over the base path for this filesystem's generated URLs.
if (! is_null($url = $this->driver->getConfig()->get('url'))) {
if (! is_null($url = $this->driver->getConfig()->get('url_temporary'))) {
$uri = $this->replaceBaseUrl($uri, $url);
}

Expand Down