Skip to content

[5.x] Prevent using the reserved horizon Redis connection name #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2025
Merged

[5.x] Prevent using the reserved horizon Redis connection name #1615

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
546753d
feat: prevent using horizon redis connection name
amirhshokri Oct 3, 2025
47a7e9f
refactor: move checkIsReservedConnectionName method to service provider
amirhshokri Oct 4, 2025
3d281fb
formatting
taylorotwell Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
formatting
  • Loading branch information
@taylorotwell
taylorotwell committed Oct 4, 2025
commit 3d281fbdda9221c1d4c7d6ac11a99e01559a31ac
27 changes: 7 additions & 20 deletions src/HorizonServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,15 @@ protected function configure()
__DIR__.'/../config/horizon.php', 'horizon'
);

$horizonRedisConnectionName = config('horizon.use', 'default');
$connection = config('horizon.use', 'default');

$this->checkIsReservedConnectionName($horizonRedisConnectionName);
if ($connection === 'horizon' || config()->has('database.redis.horizon')) {
throw new InvalidArgumentException(
'The Redis connection name [horizon] is reserved for internal use.'
);
}

Horizon::use($horizonRedisConnectionName);
Horizon::use($connection);
}

/**
Expand Down Expand Up @@ -194,21 +198,4 @@ protected function registerQueueConnectors()
});
});
}

/**
* Check if a given Redis connection name is reserved by Horizon.
*
* @param string $connection
* @return void
*
* @throws \Exception
*/
protected function checkIsReservedConnectionName(string $connection): void
{
if ($connection === 'horizon' || config()->has('database.redis.horizon')) {
throw new InvalidArgumentException(
'The Redis connection name [horizon] is reserved for internal use.'
);
}
}
}