Skip to content

Add error handling for serializing of request headers #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

Add error handling for serializing of request headers #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Sensors/RequestSensor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Laravel\Nightwatch\Concerns\RecordsContext;
use Laravel\Nightwatch\Concerns\RedactsHeaders;
use Laravel\Nightwatch\ExecutionStage;
use Laravel\Nightwatch\Facades\Nightwatch;
use Laravel\Nightwatch\Records\Request as RequestRecord;
use Laravel\Nightwatch\State\RequestState;
use Laravel\Nightwatch\Types\Str;
Expand All @@ -21,6 +22,7 @@
use function is_numeric;
use function is_string;
use function json_encode;
use function rescue;
use function sort;
use function strlen;
use function tap;
Expand Down Expand Up @@ -138,7 +140,15 @@ function () use ($record) {
'peak_memory_usage' => $this->requestState->peakMemory(),
'exception_preview' => Str::tinyText($this->requestState->exceptionPreview),
'context' => $this->serializedContext(),
'headers' => Str::text(json_encode((object) $this->redactHeaders($record->headers, $this->redactHeaders)->all(), JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_PRESERVE_ZERO_FRACTION)),
'headers' => rescue(
fn () => Str::text(json_encode((object) $this->redactHeaders($record->headers, $this->redactHeaders)->all(), JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_PRESERVE_ZERO_FRACTION)),
'{"_nightwatch_error":"Failed to serialize headers"}',
static function ($e) {
Nightwatch::unrecoverableExceptionOccurred($e);

return false;
},
),
];
},
];
Expand Down