Skip to content

FrankenPHP: show worker startup errors if APP_DEBUG=true #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2025
Merged

FrankenPHP: show worker startup errors if APP_DEBUG=true #1055

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ba0793
Explicitly checks for debug mode on error.
Sep 4, 2025
47a1cdc
Explicitly checks for debug mode on worker start error.
Sep 4, 2025
ec25816
style ci
Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explicitly checks for debug mode on worker start error.
  • Loading branch information
a.stecher committed Sep 4, 2025
commit 47a1cdcb9e2c2e02b8e226bfc1f95e13c113d116
4 changes: 2 additions & 2 deletions bin/frankenphp-worker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@
report($e);
}

$hasDebugModeEnabled = app()->has('config') && app()->hasDebugModeEnabled();
$debugMode = $_ENV['APP_DEBUG'] ?? $_SERVER['APP_DEBUG'] ?? 'false';

$response = new Response(
$hasDebugModeEnabled ? (string)$e : 'Internal Server Error',
$debugMode === 'true' ? (string)$e : 'Internal Server Error',
500,
[
'Status' => '500 Internal Server Error',
Expand Down