Skip to content

Conversation

X-Coder264
Copy link
Contributor

The makeWith method is not on the contract and it is just an alias for the make method which is on the contract.

@paras-malhotra
Copy link
Contributor

paras-malhotra commented Nov 18, 2018

@X-Coder264 Telescope does not refer to the contract in the package. It always refers to the concrete implementation so it's really not a violation.

@X-Coder264
Copy link
Contributor Author

@paras-malhotra Actually it does refer to the contract in the package (here and on a bunch of other places as well). Actually only Laravel\Telescope\Telescope class refers to the concrete implementation in the docblock (and two or three other classes), in the rest of the code the contract is referenced.

@paras-malhotra
Copy link
Contributor

Aah I see, makes sense.

@taylorotwell taylorotwell merged commit 3263992 into laravel:1.0 Nov 18, 2018
@X-Coder264 X-Coder264 deleted the fix-contract-violation branch November 18, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants