Add GitHub account connection and disconnection functionality #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
requested changes
Oct 9, 2025
| <a href="#api_token_settings_heading" class="text-gray-600 hover:bg-gray-50 hover:text-gray-900 flex items-center px-3 py-2 text-sm font-medium rounded-md"> | ||
| <a href="#github_settings_heading" | ||
| class="text-gray-600 hover:bg-gray-50 hover:text-gray-900 flex items-center px-3 py-2 text-sm font-medium rounded-md"> | ||
| <x-icon-github-line class="text-gray-400 shrink-0 -ml-1 mr-3 h-6 w-6" /> |
There was a problem hiding this comment.
Can we just re-use the GitHub icon from simple-icons here that's also used in other places on the site?
There was a problem hiding this comment.
It's not in the same style as the other icons, that's why I didn't use it.
Simple icons <x-si-github/>
The icon I added (the closest in style that I could find):
There was a problem hiding this comment.
It's fine really. I would prefer to use the same icon everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #659