Skip to content

Conversation

@roninjin10
Copy link
Contributor

fixes #3389

@roninjin10 roninjin10 requested review from alvrs and ludns as code owners June 15, 2025 09:36
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2025

🦋 Changeset detected

Latest commit: d6728b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/cli Patch
@latticexyz/entrykit Patch
@latticexyz/store-sync Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-modules Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/paymaster Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store Patch
@latticexyz/utils Patch
vite-plugin-mud Patch
@latticexyz/world-consumer Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frolic frolic merged commit 8fad4be into latticexyz:main Jun 17, 2025
14 of 17 checks passed
@frolic
Copy link
Member

frolic commented Jun 19, 2025

I would have thought this would work across node versions, but seems like have to choose between 18, 20, and 22?

@roninjin10
Copy link
Contributor Author

Ah yea that is likely a good point. Just sharing what I know about this

  • assert got completely deprecated (and it was never standardized) so for sure don't want to use it
  • with has a specification that says the entire way the module is loaded is allowed to be changed from how it would be loaded without the with
  • Your tsup config should be defaulting to compiling to node16 support but I am guessing that it doesn't apply to mdoules? I'm not sure if tsup has module specifications like tsconfig has

Might be worth just removing the import attributes completely until it gets officially standardized

@frolic frolic mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mud cli do not work with node 22

2 participants