Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update with correct LDClient type.
  • Loading branch information
kinyoklion committed Jul 9, 2025
commit 3cb9f99c4e1fc3178d4ce1eefb8e5efa09f83fa9
12 changes: 10 additions & 2 deletions ldclient/plugin.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
from __future__ import annotations
from abc import ABCMeta, abstractmethod
from dataclasses import dataclass
from typing import Any, List, Optional
from typing import List, Optional, TYPE_CHECKING

from ldclient.context import Context
from ldclient.evaluation import EvaluationDetail, FeatureFlagsState
from ldclient.hook import Hook
from ldclient.impl import AnyNum
from ldclient.impl.evaluator import error_reason
from ldclient.interfaces import BigSegmentStoreStatusProvider, DataSourceStatusProvider, DataStoreStatusProvider, FlagTracker

if TYPE_CHECKING:
from ldclient.client import LDClient

@dataclass(kw_only=True)
class SdkMetadata:
Expand Down Expand Up @@ -70,7 +78,7 @@ def metadata(self) -> PluginMetadata:
return PluginMetadata(name='UNDEFINED')

@abstractmethod
def register(self, client: Any, metadata: EnvironmentMetadata) -> None:
def register(self, client: LDClient, metadata: EnvironmentMetadata) -> None:
"""
Register the plugin with the SDK client.

Expand Down
2 changes: 1 addition & 1 deletion ldclient/testing/test_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_example_plugin(self):

# Test hooks
sdk_metadata = SdkMetadata(name="test-sdk", version="1.0.0")
env_metadata = EnvironmentMetadata(sdk=sdk_metadata)
env_metadata = EnvironmentMetadata(sdk=sdk_metadata, sdk_key="test-key")

hooks = plugin.get_hooks(env_metadata)
self.assertEqual(len(hooks), 1)
Expand Down
Loading