Skip to content

allow any collection to be marked as read #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledermann merged 1 commit into from
Dec 4, 2017
Merged

allow any collection to be marked as read #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/unread/readable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ def mark_as_read!(target, options)

if target == :all
reset_read_marks_for_user(reader)
elsif target.is_a?(Array)
elsif target.respond_to?(:each)
mark_array_as_read(target, reader)
else
raise ArgumentError
end
end

def mark_array_as_read(array, reader)
def mark_array_as_read(collection, reader)
ReadMark.transaction do
global_timestamp = reader.read_mark_global(self).try(:timestamp)

array.each do |obj|
collection.each do |obj|
raise ArgumentError unless obj.is_a?(self)
timestamp = obj.send(readable_options[:on])

Expand Down
8 changes: 8 additions & 0 deletions spec/unread/readable_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,14 @@
}.to perform_queries(1)
end

it "should allow a collection of records to be marked as read" do
Email.mark_as_read! Email.all, for: @reader

expect(@email1.unread?(@reader)).to be_falsey
expect(@email2.unread?(@reader)).to be_falsey
end


it "should mark all objects as read" do
Email.mark_as_read! :all, for: @reader

Expand Down