Stack overflow and fabImageResource not working.

[fei0316]

Step 1: Are you in the right place?

• I have verified there are no duplicate active or recent bugs, questions, or requests
• I have verified that I am using the latest version of the library.

Step 2: Describe your environment

• Library version: 3.2.0
• Android version: 10
• Support library version: com.google.android.material:material:1.3.0
• Device brand: OnePlus
• Device model: 7 Pro
  (Also tested not working on a Xiaomi device)

Step 3: Describe the problem:

Steps to reproduce:

1. setContentDescription on SpeedDialView
2. use new SpeedDialActionItem.Builder() as before (unchanged)
3. Run app and it crashes due to stack overflow by setContentDescription calling itself too many times
4. Removing the setContentDescription line works, but the icons on the FAB are missing

Relevant Code:

        SpeedDialView speedDialView = findViewById(R.id.speedDial1);
        speedDialView.setContentDescription(getString(R.string.menu_fab_description));
        speedDialView.addActionItem(
                new SpeedDialActionItem
                        .Builder(R.id.fab_justnow, R.drawable.ic_done_black_24dp)
                        .setFabBackgroundColor(getResources().getColor(R.color.colorAccent))
                        .setContentDescription(R.string.menu_justnow)
                        .setLabel(R.string.menu_justnow)
                        .create());

    java.lang.StackOverflowError: stack size 8192KB
        at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:240)
        at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
        at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
        at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
        ...

[leinardi]

Hi @fei0316, thank you for reporting this bug. I have fixed the stack overflow, but I can't reproduce the issue with the missing icons on the action FABs.

If possible, could you please clone the project repository, checkout the master branch and try to reproduce the issue using the sample app?

My suggestion is to try to reproduce the issue modifying the MainActivity:

FloatingActionButtonSpeedDial/sample/src/main/java/com/leinardi/android/speeddial/sample/MainActivity.kt

Line 47 in dab93d5

speedDialView.addActionItem(SpeedDialActionItem.Builder(R.id.fab_no_label, R.drawable

[fei0316]

Thank you for the quick fix. I am still testing where the problem comes from. Cloning your repo and running on my device is working fine, though.
Another problem I found is that if both setLabel and setContentDescription are set on an action FAB, TalkBack will use the text from setLabel not setContentDescription. setContentDescription is only used if setLabel is not set.

[fei0316]

I have done a bit more experimenting with my app vs the sample app. I made a new activity on my app with just a FAB view. I find that just copying the layout XML and Java file for the activity into your sample project would make the icon appear, so I think that rules out any code issues. Though there are still many things I can try changing (imported libraries, resources, permissions, etc.), I think it's more efficient if you can let me know what changed from 3.1.1 to 3.2.0 and I can focus my testing on those.

Also, my app is open source here, so you can take a look if you want to.

Thank you very much!!

[leinardi]

3.1.1 was released in 2019 so lot of things have changed, especially regarding dependencies updates.
You can figure out exactly what has changed checking the git log: https://github.com/leinardi/FloatingActionButtonSpeedDial/commits/release?after=dab93d5e3d8efc984e956d4144f473505ec253d0+34&branch=release

[fei0316]

I have done more testing, and I think the problem lies in AppCompatResources.getDrawable which is in androidx.appcompat. Since the same code produces different results on my project vs yours, I suspect it's a configuration problem in my project but I have compared my Gradle and AndroidManifest file with yours and couldn't find anything suspicious. I'm really stuck on how to fix the problem to be honest.

[leinardi]

Unfortunately I do not have time to do it myself but could you double check if you are using the exact same version of all the dependencies? Also, try to remove some dependencies that are not in the sample app of speed dial, just for test, to see if maybe some transient dependency is messing with the library.

This might also help you: https://docs.gradle.org/current/userguide/viewing_debugging_dependencies.html

[xoif]

The update from 3.1.1 to 3.2.0 also led to missing fab icons in my project. I didn't find the time yet to further investigate the root cause (especially as 3.1.1 is running perfectly for me). Still I have the feeling that this could be related to the fact that I'm using vector drawables and not regular png drawables as icons.

[ziegenberg]

Updating to version 3.2.0, I can confirm that the fab icons go missing. For andOTP I tried to update the dependency: andOTP/andOTP#843; you can check out this PR.

[leinardi]

Could someone experiencing the issue try to reproduce it using the sample app?
https://github.com/leinardi/FloatingActionButtonSpeedDial/tree/master/sample

If you are able to reproduce it, please let me know the version of Android that you tested it on.

[moisoni97]

I have the same problem with fab icons go missing.
I've tried to reproduce the problem but I can't. I have implemented the exact same code from my project into the sample app and it just works.

One thing that I notice and for now is a workaround, setting an image tint color makes the image appear:
.setFabImageTintColor(ContextCompat.getColor(mActivity, R.color.white))

Another thing is that, SpeedDialView now responds to system lightning (DarkMode and LightMode) and changes it's behaviour accordingly:

-icons are tinted automatically in an unpleasant way so it's better to ovrride this behaviour with .setFabImageTintColor(ContextCompat.getColor(mActivity, R.color.white))

-label background changes color automatically . Here we can use .setLabelBackgroundColor(ContextCompat.getColor(mActivity, R.color.white)) to stop changing color.