Skip to content

Fix r to work in visual block state #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cxxxr merged 5 commits into from
Sep 1, 2023
Merged

Fix r to work in visual block state #1036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f860d52
Fix 'r' to work in visual block state. (ref #1033)
fukamachi Aug 31, 2023
0c5581d
Delete *operator-pending-state-p* flag.
fukamachi Aug 31, 2023
084c9e5
Refactor by using with-temporary-state.
fukamachi Aug 31, 2023
114b0b3
Fix :move-point to work with visual block state.
fukamachi Aug 31, 2023
08cb4a3
Add tests for vi-replace-char (r).
fukamachi Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix :move-point to work with visual block state.
  • Loading branch information
@fukamachi
fukamachi committed Sep 1, 2023
commit 114b0b36d2a87cb02eeb2b863d677501b72dea9b
9 changes: 8 additions & 1 deletion extensions/vi-mode/commands/utils.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,14 @@
(values start end type)
(values start end))
(when move-point
(move-point (current-point) start)))))
(if (eq type :block)
(with-point ((p (current-point)))
(move-to-line p (min (line-number-at-point start)
(line-number-at-point end)))
(move-to-column p (min (point-charpos start)
(point-charpos end)))
(move-point (current-point) p))
(move-point (current-point) start))))))

(defun call-define-operator (fn &key keep-visual restore-point)
(with-point ((*vi-origin-point* (current-point)))
Expand Down