Skip to content

[VI-MODE] • Enhance define-vi-state to allow expose more of the defclass CLOS functionality.#700

Merged
cxxxr merged 10 commits intolem-project:mainfrom
theangelperalta:refactor/visual-state-clos
Jun 10, 2023
Merged

[VI-MODE] • Enhance define-vi-state to allow expose more of the defclass CLOS functionality.#700
cxxxr merged 10 commits intolem-project:mainfrom
theangelperalta:refactor/visual-state-clos

Conversation

@theangelperalta
Copy link
Copy Markdown
Contributor

@theangelperalta theangelperalta commented Jun 9, 2023

The plan is to use inheritance to reduce code redundancy and improve the extensibility of vi-states, such as visual state. Currently, visual state has three sub states (visual-char, visual-line, visual-block), which produce code redundancy with state changes.

TODO: Follow-up with PR to refactor redundancy visual state.

@theangelperalta theangelperalta marked this pull request as ready for review June 9, 2023 00:12
@theangelperalta
Copy link
Copy Markdown
Contributor Author

@cxxxr, this PR is ready for reviewing.

@cxxxr
Copy link
Copy Markdown
Member

cxxxr commented Jun 10, 2023

@theangelperalta
It's very good.
There is a behavior change in normal-mode and insert-mode where the cursor color is the same in both modes, is this intended?

@theangelperalta
Copy link
Copy Markdown
Contributor Author

theangelperalta commented Jun 10, 2023

@theangelperalta It's very good. There is a behavior change in normal-mode and insert-mode where the cursor color is the same in both modes, is this intended?

Nice catch @cxxxr, it I'll address the unintended behavioral change.

@cxxxr
Copy link
Copy Markdown
Member

cxxxr commented Jun 10, 2023

Thank you so much!
I think it is very good.

@cxxxr cxxxr merged commit 961b992 into lem-project:main Jun 10, 2023
@cxxxr cxxxr mentioned this pull request Jul 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants