This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Suggest behavior callbacks#206
Merged
Merged
Conversation
scohen
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic behavior callback completion. I think this is a good start, but I think there's still more that can be done here, and more thorough tests probably. Please let me know anything else I should add or cover.
Improvements I'd love to see (but maybe not in this PR) are:
do/endto the end of the suggestion snippet for callbacksdef|when inside a module thatuses a behaviorThoughts?