Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

[issue-178] Snippet translations for macro#208

Merged
Sleepful merged 1 commit into
mainfrom
issue-178/enhance-snippets-for-test-macro
Jun 28, 2023
Merged

[issue-178] Snippet translations for macro#208
Sleepful merged 1 commit into
mainfrom
issue-178/enhance-snippets-for-test-macro

Conversation

@Sleepful

@Sleepful Sleepful commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Open PR, should be ready for test macros

Sleepful
Sleepful commented Jun 7, 2023
View reviewed changes
Comment thread apps/server/test/lexical/server/code_intelligence/completion/translations/macro_test.exs Outdated
Sleepful
Sleepful commented Jun 7, 2023
View reviewed changes
Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
scohen
scohen reviewed Jun 7, 2023
View reviewed changes
Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
@Sleepful

Sleepful commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Todo:

  • Merge main and fix up boost: “Boosting now takes an item rather than the sort text, and has a different signature.”
  • Improve assert, assert_*...
  • Look through ExUnit for the others
    I will do those in another PR

@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch 2 times, most recently from 2896270 to 42ba33e Compare June 22, 2023 07:09
scohen
scohen reviewed Jun 22, 2023
View reviewed changes
Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
scohen
scohen reviewed Jun 22, 2023
View reviewed changes
Comment thread apps/server/test/lexical/server/code_intelligence/completion/translations/macro_test.exs Outdated
Comment thread apps/server/test/lexical/server/code_intelligence/completion/translations/macro_test.exs Outdated
@Sleepful Sleepful marked this pull request as ready for review June 23, 2023 06:20
@Sleepful Sleepful mentioned this pull request Jun 23, 2023
Closed
@Sleepful Sleepful requested review from scohen and scottming June 23, 2023 20:31
@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch from b4f8157 to ea218a3 Compare June 24, 2023 02:28
@Sleepful

Sleepful commented Jun 24, 2023

Copy link
Copy Markdown
Member Author

@scohen ready :)
consolidated into a single commit

scohen
scohen approved these changes Jun 28, 2023
View reviewed changes

@scohen scohen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the one comment, then you're good.

Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
@Sleepful Sleepful force-pushed the issue-178/enhance-snippets-for-test-macro branch from ea218a3 to b5e727a Compare June 28, 2023 22:15
@Sleepful Sleepful merged commit eb384c3 into main Jun 28, 2023
@Sleepful Sleepful deleted the issue-178/enhance-snippets-for-test-macro branch June 28, 2023 22:16
@scohen

scohen commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator

Fixes #178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@scottming scottming Awaiting requested review from scottming
1 more reviewer
@scohen scohen scohen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sleepful @scohen @scottming