This repository was archived by the owner on Aug 30, 2025. It is now read-only.
GitHub Actions improvements#245
Merged
Merged
Conversation
scohen
force-pushed
the
improve-actions
branch
10 times, most recently
from
7e7318b to
d79b0b8
Compare
The old workflow was serial, and was taking way too long after the changes to the product structure. This is due to the dialyzer plt having to be modified by all the different usages of it. Having each subproject and the umbrella use different PLT files fixed that problem. I also parallelized the static analysis, dialyzer and tests so they run more quickly.
The plugins diagnostic result convertible was being defined in a project that did not have access to the plugins repo. Moving it to server fixes the dependency issues.
scottming
reviewed
Jun 29, 2023
scottming
approved these changes
Jun 29, 2023
scottming
left a comment
scottming
left a comment
Collaborator
There was a problem hiding this comment.
Look great to me, but I do not have much experience in the CI area, so maybe @Blond11516 can take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our github actions were taking a while. This PR does the following:
The result is that tests used to take around 7 minutes to run, and now they run in 3. More importantly, by splitting things up into three jobs, we get more errors all at once. You see the static analysis results in 20 seconds, and dialyzer in about 40 seconds. You also get to see failures for all three jobs separately. Prior, you would need to have successful static analysis and dialyzer before your tests would even run, which meant you'd often have to go back to CI multiple times before a successful run.