This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Fixing flaky tests#252
Merged
Merged
Conversation
scohen
force-pushed
the
fix-flaky-tests
branch
2 times, most recently
from
769b664 to
ad21437
Compare
These tests were failing occationally, and when I looked at them, they were doing the wrong thing.
scohen
force-pushed
the
fix-flaky-tests
branch
2 times, most recently
from
a1fdf3f to
7ed7b29
Compare
Collaborator
Author
|
Going to merge this, as it's very annoying to see flakes happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests here were failing occasionally, and the coordinator test was actually not cleaning up after itself and was not testing the right things. This fixes all of those problems.