This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Handle presense of multiple version managers#311
Merged
Conversation
Check in turn for presense of asdf/rtx _and_ if erl/elixir are installed when resolving executable paths
scohen
approved these changes
Aug 4, 2023
scottming
approved these changes
Aug 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Had an issue locally when both
asdfandrtxwere installed, but Elixir/Erlang versions were handled byrtx, so that the elixir executable was not found, and looked into it.I'm aware it's an unusual case, but feel the changes couldn't hurt.
My thinking is also that although version managers are installed, they may not be used to handle Elixir/Erlang, in which case the fallback of checking for the executables directly is still handy.
The changes here basically combine the check for a version manager and the executable into one step, also making it possible to use executables installed by different means.