Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Handle presense of multiple version managers#311

Merged
scohen merged 1 commit into
lexical-lsp:mainfrom
awerment:improve-version-manager-checks
Aug 7, 2023
Merged

Handle presense of multiple version managers#311
scohen merged 1 commit into
lexical-lsp:mainfrom
awerment:improve-version-manager-checks

Conversation

@awerment

@awerment awerment commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Hi 👋

Had an issue locally when both asdf and rtx were installed, but Elixir/Erlang versions were handled by rtx, so that the elixir executable was not found, and looked into it.

I'm aware it's an unusual case, but feel the changes couldn't hurt.

My thinking is also that although version managers are installed, they may not be used to handle Elixir/Erlang, in which case the fallback of checking for the executables directly is still handy.

The changes here basically combine the check for a version manager and the executable into one step, also making it possible to use executables installed by different means.

Check in turn for presense of asdf/rtx _and_ if erl/elixir are installed
when resolving executable paths
@scohen scohen merged commit 96649b5 into lexical-lsp:main Aug 7, 2023
@awerment awerment deleted the improve-version-manager-checks branch August 7, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants