Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Suggest a module name for defmodule completion#338

Merged
scohen merged 2 commits into
mainfrom
defmodule-suggest-name
Aug 25, 2023
Merged

Suggest a module name for defmodule completion#338
scohen merged 2 commits into
mainfrom
defmodule-suggest-name

Conversation

@scohen

@scohen scohen commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

The defmodule completion snippet now does a best-effort attempt to guess the module name.

The guessing takes into account lib, test and test/support directories, and if it doesn't detect any of them, just uses the file name.

The defmodule completion snippet now does a best-effort attempt to
guess the module name.

The guessing takes into account lib, test and test/support
directories, and if it doesn't detect any of them, just uses the file name.
@scohen scohen requested a review from scottming August 16, 2023 18:33
@scohen scohen changed the title Suggest module name for defmodule Suggest a module name for defmodule completion Aug 16, 2023
@scohen

scohen commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator Author

@scottming, thoughts?

Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated
@scohen scohen merged commit 28501cb into main Aug 25, 2023
@scohen scohen deleted the defmodule-suggest-name branch August 25, 2023 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants