This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Fixed index store test failure#365
Merged
Merged
Conversation
zachallaun
approved these changes
Sep 13, 2023
Depending on what was run prior, the store test suite might encounter a previously built index, which would make the create index tests fail. The change here deletes the index in a setup_all block, so the test suite starts with an empty index, and keeps the on_exit handler that deletes the index at the end of each test.
scohen
force-pushed
the
fix-store-test-failure
branch
from
daef53e to
7cd0511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on what was run prior, the store test suite might encounter a previously built index, which would make the create index tests fail. The change here deletes the index in a setup_all block, so the test suite starts with an empty index, and keeps the on_exit handler that deletes the index at the end of each test.