This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Aliases was confused by nested non-module blocks#368
Merged
Conversation
Aliases would get confused if a module had another block that didn't define another module (like in a DSL). This was because it only popped a single scope at a time, and if several scopes ended on the same line, only the inner scope would be popped. Calling the pop funcion recursively solves the issue.
zachallaun
approved these changes
Sep 14, 2023
zachallaun
left a comment
zachallaun
left a comment
Collaborator
There was a problem hiding this comment.
Your explanation and the fix make sense to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases would get confused if a module had another block that didn't define another module (like in a DSL). This was because it only popped a single scope at a time, and if several scopes ended on the same line, only the inner scope would be popped. Calling the pop funcion recursively solves the issue.