Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Removed unhelpful completion for :: symbol#485

Merged
scohen merged 4 commits into
lexical-lsp:mainfrom
mdshamoon:issue/474
Nov 14, 2023
Merged

Removed unhelpful completion for :: symbol#485
scohen merged 4 commits into
lexical-lsp:mainfrom
mdshamoon:issue/474

Conversation

@mdshamoon

@mdshamoon mdshamoon commented Nov 12, 2023

Copy link
Copy Markdown
Contributor

Solution description

As mentioned by scohen added this symbol :: in the list of @snippet_macros to not show any completions.
Target issue #474

This PR is ready for review. Feedbacks would be really helpful

Comment thread apps/server/lib/lexical/server/code_intelligence/completion/translations/macro.ex Outdated

@scottming scottming left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@scohen scohen merged commit bb39bb2 into lexical-lsp:main Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants