Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Fix do completing to defmodule in VSCode#642

Merged
scohen merged 3 commits into
lexical-lsp:mainfrom
Moosieus:do_end_vscode_fix
Mar 12, 2024
Merged

Fix do completing to defmodule in VSCode#642
scohen merged 3 commits into
lexical-lsp:mainfrom
Moosieus:do_end_vscode_fix

Conversation

@Moosieus

@Moosieus Moosieus commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator

Pursuant to: https://discord.com/channels/269508806759809042/918183981344772117/1214563122686206033

objectuser — Today at 8:20 AM
I'm using Lexical in VSCode. When I'm creating a do block, the first completion is defmodule and there's no completion listed in the pop-up for just do...end. Should I just use user snippets for a do...end block or is there a better way to configure these completions?

(From Elixir Discord)

Fixes include:

  • Include partial d| in should_emit_do_end_snippet
  • Add filter_text: "do" for more accurate fuzzy matching

This may warrant user-testing across different editors to ensure existing completions remain consistent, as they may convert user-input-over-time to textDocument/completion requests differently.

Moosieus added 3 commits March 5, 2024 23:56
* Include partial `d|` in `should_emit_do_end_snippet`
* Add `filter_text: "do"` for more accurate fuzzy matching
Comment thread apps/server/lib/lexical/server/code_intelligence/completion.ex
@scohen scohen merged commit 595978a into lexical-lsp:main Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants