add support for plan9 #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user_plan9.go is almost identical to user_posix. test about failing bad connection is failing on plan9, more in a next commit.
i ran into this while adding plan9 support (postgres doesn't run on plan9). unrelated, this test is still broken on plan9: conn_test.go:769: expected use of closed error, got write tcp 192.168.178.144:55579->192.168.178.38:5432: bad arg in system call tcp closing apparently works slightly differently on plan9, where it doesn't return the error string expected by the tests. no big deal, and this patch improves the general situation.
rogerhub
reviewed
Apr 23, 2018
conn_test.go
Outdated
| if port == "" { | ||
| port = "5432" | ||
| } | ||
| addr := host + ":" + port |
There was a problem hiding this comment.
net.JoinHostPort? (in case host is v6 for some reason)
would make it work with ipv6 ip addresses. suggested by roger chen in pull request comment.
Contributor
Author
|
can someone restart the build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this compile (and work) by adding a file user_plan9.go. It's nearly identical to the posix version.
On plan9 the test TestCloseBadConn in conn_test.go was failing. The hardcoded localhost:5432 won't work (postgres isn't available on plan9). The README already encourages you to use environment variables to override database connection parameters, so this patch makes the code look at env vars.