Fixing bug in handling of server version parsing for Postgresql 10+ #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriikushch
left a comment
andriikushch
left a comment
There was a problem hiding this comment.
Apart from tiny comments looks reasonable to me.
| if err == nil { | ||
| cn.parameterStatus.serverVersion = major1*10000 + major2*100 + minor | ||
| // if the version string contains at least major1, set the server version | ||
| n, _ := fmt.Sscanf(r.string(), "%d.%d.%d", &major1, &major2, &minor) |
There was a problem hiding this comment.
Hi @xstevens !
I think it still makes sense to check for error here because Sscanf function can return an error and n > 0 at the same time. What do you think about?
| writer.string(versionStr) | ||
| reader := readBuf(writer.buf) | ||
| c.processParameterStatus(&reader) | ||
| expectedVersionNum := version |
There was a problem hiding this comment.
@xstevens Do you think we can avoid this extra variable here?
DmitriyVTitov
approved these changes
Aug 1, 2019
pavelblossom
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server versioning scheme changed in Postgresql 10+. They've moved to two-part rather than three-part versioning. For example,
10.5rather than10.5.0. They've also changed the calculation of theserver_version_numinteger. Full details can be found in the libpq status documentation.On the face of it this doesn't seem like a huge deal, but it affects
encoding.go. In particular theencodeByteafunction uses server version check to see if it should use hex encoding.