fix: flaky TestFindPeerQueryMinimal #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791
Using
testFindPeerQuerywith 2bootstrappersbut only a singlebootstrapConnsleads to partitioning. Basically each node connects to one of the two bootstrappers at random. Bootstrappers aren't connected to each other. The only bridge between the 2 partitions isguy, which is connected to all bootstrappers.While not critical, it may require nodes to perform a high number of routing table refreshes to converge to a stable state. The test is sometimes failing because nodes in both partitions may not know each other.
Using a single bootstrapper for the minimal test doesn't seem crazy, and solves the partitions issue.