Skip to content

fix: flaky TestInvalidServer #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: flaky TestInvalidServer #1032

merged 2 commits into from
Feb 18, 2025

Conversation

@guillaumemichel
Copy link
Collaborator

@guillaumemichel guillaumemichel commented Feb 18, 2025

Fixes #1023

  • I wasn't able to reproduce the flake locally
  • Certainly due to slow execution
  • Increased time tolerance

@guillaumemichel guillaumemichel requested a review from a team as a code owner February 18, 2025 14:25
@guillaumemichel
Copy link
Collaborator Author

guillaumemichel commented Feb 18, 2025

Another failure: https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/13392832352/job/37404382536?pr=1032#step:14:54

@guillaumemichel guillaumemichel merged commit 6284851 into master Feb 18, 2025
7 checks passed
@guillaumemichel guillaumemichel deleted the fix/1023 branch February 18, 2025 16:49
@BrewTestBot BrewTestBot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky TestInvalidServer

2 participants

@guillaumemichel