Skip to content

Conversation

@guillaumemichel
Copy link
Collaborator

Fixes #791

  • to make sure that all peers are found, set Resiliency to bucketSize
  • if self (guy) is among the closest peers of the key that is looked up, the test may fail
    • in this case we don't look for the bucketSize closest peers, but for the bucketSize+1 closest peers, excluding self, hence the last peer may not be correct
  • fix: if self is among the closest peers, add it to the list of returned peers when checking for the closest peers

@guillaumemichel guillaumemichel requested a review from a team as a code owner February 19, 2025 16:05
@guillaumemichel guillaumemichel merged commit c1e046d into master Feb 19, 2025
7 checks passed
@guillaumemichel guillaumemichel deleted the fix/791 branch February 19, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky TestFindPeerQueryMinimal test

2 participants