fix: crawler polluting peerstore #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sukunrt
reviewed
Feb 27, 2025
sukunrt
approved these changes
Feb 28, 2025
sukunrt
approved these changes
Mar 3, 2025
This was referenced Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ipfs/kubo#10737
Problem
The crawler used by the Accelerated DHT Client crawls the network, and write all discovered addresses to the host's peerstore for 30 minutes, without checking them first. These addresses aren't flushed after identify is run. We end up with many stale addresses polluting the host peerstore.
Fix
The crawler has its own temporary peerstore, and only persists addresses reported by identify to the host peerstore for the required 30 minutes.