Skip to content

Conversation

@guillaumemichel
Copy link
Collaborator

  • release v0.30.0
  • retracting v0.29.2 which contained a breaking change (removal of OpenCensus metrics)

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Suggested version: 0.30.0

Comparing to: v0.29.2 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# github.com/libp2p/go-libp2p-kad-dht
## incompatible changes
OnRequestHook: removed

# github.com/libp2p/go-libp2p-kad-dht/fullrt
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/fullrt/dht.go:1426:26: invalid map key type multiaddr.Multiaddr

# github.com/libp2p/go-libp2p-kad-dht/pb
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/pb/dht.pb.go:360:26: m.Record.MarshalToSizedBuffer undefined (type *"github.com/libp2p/go-libp2p-record/pb".Record has no field or method MarshalToSizedBuffer)
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/pb/dht.pb.go:461:16: m.Record.Size undefined (type *"github.com/libp2p/go-libp2p-record/pb".Record has no field or method Size)
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/pb/dht.pb.go:628:23: m.Record.Unmarshal undefined (type *"github.com/libp2p/go-libp2p-record/pb".Record has no field or method Unmarshal)

## incompatible changes
(*Message).GetCloserPeers: changed from func() []*Message_Peer to func() []Message_Peer
(*Message).GetProviderPeers: changed from func() []*Message_Peer to func() []Message_Peer
(*Message).ProtoReflect: removed
(*Message_Peer).GetId: removed
(*Message_Peer).ProtoReflect: removed
File_github.com_libp2p_go_libp2p_kad_dht_pb_dht_proto: removed
Message.CloserPeers: changed from []*Message_Peer to []Message_Peer
Message.ProviderPeers: changed from []*Message_Peer to []Message_Peer
Message_ConnectionType.Descriptor: removed
Message_ConnectionType.Enum: removed
Message_ConnectionType.Number: removed
Message_ConnectionType.Type: removed
Message_MessageType.Descriptor: removed
Message_MessageType.Enum: removed
Message_MessageType.Number: removed
Message_MessageType.Type: removed
Message_Peer.Id: changed from []byte to byteString
PBPeerToPeerInfo: changed from func(*Message_Peer) github.com/libp2p/go-libp2p/core/peer.AddrInfo to func(Message_Peer) github.com/libp2p/go-libp2p/core/peer.AddrInfo
PBPeersToPeerInfos: changed from func([]*Message_Peer) []*github.com/libp2p/go-libp2p/core/peer.AddrInfo to func([]Message_Peer) []*github.com/libp2p/go-libp2p/core/peer.AddrInfo
PeerInfosToPBPeers: changed from func(github.com/libp2p/go-libp2p/core/network.Network, []github.com/libp2p/go-libp2p/core/peer.AddrInfo) []*Message_Peer to func(github.com/libp2p/go-libp2p/core/network.Network, []github.com/libp2p/go-libp2p/core/peer.AddrInfo) []Message_Peer
PeerRoutingInfosToPBPeers: changed from func([]PeerRoutingInfo) []*Message_Peer to func([]PeerRoutingInfo) []Message_Peer
RawPeerInfosToPBPeers: changed from func([]github.com/libp2p/go-libp2p/core/peer.AddrInfo) []*Message_Peer to func([]github.com/libp2p/go-libp2p/core/peer.AddrInfo) []Message_Peer
## compatible changes
(*Message).Marshal: added
(*Message).MarshalTo: added
(*Message).MarshalToSizedBuffer: added
(*Message).Size: added
(*Message).Unmarshal: added
(*Message).XXX_DiscardUnknown: added
(*Message).XXX_Marshal: added
(*Message).XXX_Merge: added
(*Message).XXX_Size: added
(*Message).XXX_Unmarshal: added
(*Message_Peer).Marshal: added
(*Message_Peer).MarshalTo: added
(*Message_Peer).MarshalToSizedBuffer: added
(*Message_Peer).Size: added
(*Message_Peer).Unmarshal: added
(*Message_Peer).XXX_DiscardUnknown: added
(*Message_Peer).XXX_Marshal: added
(*Message_Peer).XXX_Merge: added
(*Message_Peer).XXX_Size: added
(*Message_Peer).XXX_Unmarshal: added
ErrIntOverflowDht: added
ErrInvalidLengthDht: added
ErrUnexpectedEndOfGroupDht: added
Message.XXX_NoUnkeyedLiteral: added
Message.XXX_sizecache: added
Message.XXX_unrecognized: added
Message_Peer.XXX_NoUnkeyedLiteral: added
Message_Peer.XXX_sizecache: added
Message_Peer.XXX_unrecognized: added

# github.com/libp2p/go-libp2p-kad-dht/providers
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/providers/providers_manager.go:150:9: gcQuery.Close() (no value) used as value
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/providers/providers_manager.go:183:16: gcQuery.Close() (no value) used as value

# diagnostics
go.mod: the following requirements are needed
	[email protected]
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Cannot suggest a release version.
Errors were found.

gocompat says:

HEAD is now at 10cab74 new version (#1052)
Previous HEAD position was 10cab74 new version (#1052)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@guillaumemichel guillaumemichel merged commit 7c3bb2a into master Mar 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants