provider: SweepingProvider options #1100
Closed
+1,047
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
force-pushed
the
sweepingprovider-options
branch
from
de67e6c to
170d6e8
Compare
guillaumemichel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1095
Depends on:
Defines options used to create the
SweepingReprovider. Some options are related to functionalities that are not yet included in the code at this stage of the review process.If it makes more sense, I could include each option in the same PR as its associated feature. I just found it easier to include everything at once. If this gets merged in the master PR before we need to change an option related to a feature, we can work on it in the PR related to the feature.
If some more options are needed later, they will be added in the PR associated with the new feature. We can consider this part of the code base as frozen.