provider: ProvideStatus interface #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
changed the title
Closed
17 tasks
lidel
reviewed
Jul 21, 2025
lidel
reviewed
Jul 22, 2025
lidel
approved these changes
Jul 22, 2025
Co-authored-by: Marcin Rataj <[email protected]>
gammazero
reviewed
Jul 23, 2025
Contributor
gammazero
left a comment
gammazero
left a comment
There was a problem hiding this comment.
Fix comment, then OK to merge
Collaborator
Author
|
I renamed // For `StateQueued` or `StateUnknown`, `lastProvide` is the zero `time.Time`. |
gammazero
approved these changes
Jul 23, 2025
guillaumemichel
changed the base branch from
sweepingprovider-interface
to
provider
guillaumemichel
force-pushed
the
provider-interface-LastProvideAt
branch
from
4640796 to
dcf1438
Compare
guillaumemichel
added a commit
that referenced
this pull request
Aug 19, 2025
* SweepingProvider interface * updated interface to address reviews * LastProvideAt * ProvideStatus * Update provider/provider.go Co-authored-by: Marcin Rataj <[email protected]> * renamed `ts` to `lastProvide` * add TODO for missing implementation --------- Co-authored-by: Marcin Rataj <[email protected]>
guillaumemichel
added a commit
to guillaumemichel/go-libp2p-kad-dht
that referenced
this pull request
Sep 17, 2025
* SweepingProvider interface * updated interface to address reviews * LastProvideAt * ProvideStatus * Update provider/provider.go Co-authored-by: Marcin Rataj <[email protected]> * renamed `ts` to `lastProvide` * add TODO for missing implementation --------- Co-authored-by: Marcin Rataj <[email protected]>
guillaumemichel
added a commit
that referenced
this pull request
Sep 17, 2025
* SweepingProvider interface * updated interface to address reviews * LastProvideAt * ProvideStatus * Update provider/provider.go Co-authored-by: Marcin Rataj <[email protected]> * renamed `ts` to `lastProvide` * add TODO for missing implementation --------- Co-authored-by: Marcin Rataj <[email protected]>
guillaumemichel
added a commit
that referenced
this pull request
Sep 18, 2025
* SweepingProvider interface * updated interface to address reviews * LastProvideAt * ProvideStatus * Update provider/provider.go Co-authored-by: Marcin Rataj <[email protected]> * renamed `ts` to `lastProvide` * add TODO for missing implementation --------- Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1095
Depends on #1098
Interface for polling the provide status of a specific key. Since this method isn't required for the provider to operate, this method isn't included in the
DHTProviderinterface #1093.Merging this PR isn't urgent, since the method isn't implemented yet in #1082, and it isn't required for the providing to work.