Skip to content

refactor(provider): closestPeerToPrefix coverage trie #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2025
Merged

refactor(provider): closestPeerToPrefix coverage trie #1156

merged 6 commits into from
Sep 25, 2025

Conversation

@guillaumemichel
Copy link
Collaborator

@guillaumemichel guillaumemichel commented Sep 24, 2025

Refactor of closestPeerToPrefix to use a trie to ensure keyspace coverage (instead of binary prefix stack).

@guillaumemichel guillaumemichel requested a review from a team as a code owner September 24, 2025 11:07
@guillaumemichel guillaumemichel mentioned this pull request Sep 23, 2025
Closed
49 tasks
@guillaumemichel guillaumemichel marked this pull request as draft September 24, 2025 11:57
@guillaumemichel guillaumemichel marked this pull request as ready for review September 24, 2025 14:42
@guillaumemichel guillaumemichel marked this pull request as draft September 25, 2025 08:14
@guillaumemichel
Copy link
Collaborator Author

guillaumemichel commented Sep 25, 2025

After a manual test on the amino DHT, there are still some warnings remaining closestPeersToPrefix needed more than maxPrefixSearches iterations. Investigating on the root cause.

@guillaumemichel guillaumemichel marked this pull request as ready for review September 25, 2025 09:46
lidel
lidel approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I've restored the debug level for the exploraiton message to avoid noise on INFO level

@guillaumemichel guillaumemichel merged commit 0114a72 into master Sep 25, 2025
9 checks passed
@guillaumemichel guillaumemichel deleted the refactor/closestPeersToPrefix branch September 25, 2025 15:38
@BrewTestBot BrewTestBot mentioned this pull request Oct 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel approved these changes

@gammazero gammazero Awaiting requested review from gammazero

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guillaumemichel @lidel