-
Notifications
You must be signed in to change notification settings - Fork 254
feat(provider): persist provide queue #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
approved these changes
Oct 14, 2025
Contributor
gammazero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
0c65f94 to
f4a33fa
Compare
gammazero
approved these changes
Oct 15, 2025
4 tasks
guillaumemichel
added a commit
that referenced
this pull request
Oct 20, 2025
* provider: stats * use proper struct for stats * provide queue stats * counting ongoing operations * provide counts * floatTimeSeries * draft: last metrics * refactor * gofmt * tests * bump reservedpool * make provider inside buffered.SweepingProvider public * format * fix: flaky TestStats * avg region size metric * fix: ongoing provides counter * float64 avgPrefixLen * provider: persist provide queue * persist & load provide queue to/from datastore * configure datastore * test: provide queue persistence after close * limit batch size * addressing review * test: fix edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1160
Based on #1144
Description
Add functions to persist the state of the provide queue to a datastore, and then to load persisted state from datastore back to the queue. This is required to allow resuming provide operations after a restart (see #1159).
Integrated into
SweepingProvider.Added a
TestQueuePersistence.Checklist