Skip to content

Do not call Debugf for non-debug levels in doDropRPC #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Do not call Debugf for non-debug levels in doDropRPC #580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b7b3d
do not format expensive debug messages in non-debug levels in doDropRPC
algorandskiy Sep 24, 2024
f96727a
run go mod tidy
algorandskiy Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
do not format expensive debug messages in non-debug levels in doDropRPC
  • Loading branch information
@algorandskiy
algorandskiy committed Sep 24, 2024
commit a8b7b3d679be254b10a9bf5892d5f0352a1a8121
6 changes: 5 additions & 1 deletion gossipsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (
"github.com/libp2p/go-libp2p/core/protocol"
"github.com/libp2p/go-libp2p/core/record"
"github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoremem"

"go.uber.org/zap/zapcore"
)

const (
Expand Down Expand Up @@ -1334,7 +1336,9 @@ func (gs *GossipSubRouter) sendRPC(p peer.ID, out *RPC, urgent bool) {
}

func (gs *GossipSubRouter) doDropRPC(rpc *RPC, p peer.ID, reason string) {
log.Debugf("dropping message to peer %s: %s", p, reason)
if log.Level() <= zapcore.DebugLevel {
log.Debugf("dropping message to peer %s: %s", p, reason)
}
gs.tracer.DropRPC(rpc, p)
// push control messages that need to be retried
ctl := rpc.GetControl()
Expand Down
8 changes: 8 additions & 0 deletions gossipsub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3175,3 +3175,11 @@ func TestGossipsubIdontwantClear(t *testing.T) {

<-ctx.Done()
}

func BenchmarkAllocDoDropRPC(b *testing.B) {
gs := GossipSubRouter{tracer: &pubsubTracer{}}

for i := 0; i < b.N; i++ {
gs.doDropRPC(&RPC{}, "peerID", "reason")
}
}
Loading