Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pb/Makefile

This file was deleted.

21 changes: 21 additions & 0 deletions pb/gen.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// These commands work around namespace conflicts that occur when multiple
// repositories depend on .proto files with generic filenames. Due to the way
// protobuf registers files (e.g., foo.proto or pb/foo.proto), naming
// collisions can occur when the same filename is used across different
// packages.
//
// The only way to generate a *.pb.go file that includes the full package path
// (e.g., github.com/org/repo/pb/foo.proto) is to place the .proto file in a
// directory structure that mirrors its package path.
//
// References:
// - https://protobuf.dev/reference/go/faq#namespace-conflict
// - https://github.com/golang/protobuf/issues/1122#issuecomment-2045945265
//
//go:generate mkdir -p github.com/libp2p/go-libp2p-record/pb
//go:generate ln -f record.proto github.com/libp2p/go-libp2p-record/pb/
//go:generate protoc --go_out=. github.com/libp2p/go-libp2p-record/pb/record.proto
//go:generate mv -f github.com/libp2p/go-libp2p-record/pb/record.pb.go .
//go:generate rm -rf github.com

package pb
76 changes: 39 additions & 37 deletions pb/record.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion record.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//go:generate protoc -I=pb --go_out=paths=source_relative:pb pb/record.proto
package record

import (
Expand Down
Loading