fix(libp2phttp): Fix relative to absolute multiaddr URI logic #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Feb 25, 2025
Comment on lines
+530
to
+531
| locationHeader := resp.Header.Get("Location") | ||
| if locationHeader != "" { |
Member
There was a problem hiding this comment.
I'm curious, why didn't this work in the previous version where we used
resp.Location
This under the hood resolves the relative path(or at least claims to)
https://github.com/golang/go/blob/master/src/net/http/response.go#L137
Collaborator
Author
There was a problem hiding this comment.
It does, but it doesn't work with how we encode http paths in the
multiaddr URI. For multiaddr URIs in general we only use URI path components. A relative
URI reference should be relative to the http-path component not the whole
multiaddr. For example multiaddr:/ip4/1.2.3.4/http-path/foo with relative reference /bar
should resolve to multiaddr:/ip4/1.2.3.4/http-path/bar not multiaddr:/bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version did not correctly handle the case of dot segments in the path. For example if you requested
/foo/bar/and the responseLocationheader redirected you to../baz, you should go to/foo/baz/.