Skip to content

fix a compilation error introduced in 077a818. #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raulk merged 1 commit into from
May 12, 2020
Merged

fix a compilation error introduced in 077a818. #919

raulk merged 1 commit into from
May 12, 2020

Conversation

@raulk
Copy link
Member

@raulk raulk commented May 12, 2020

No description provided.

@vyzo
Copy link
Contributor

vyzo commented May 12, 2020

Still failing to compile:

*** go build github.com/libp2p/go-libp2p

# github.com/libp2p/go-libp2p/p2p/host/basic

p2p/host/basic/basic_host.go:379:30: cannot use *sr (type record.Envelope) as type *record.Envelope in assignment

@raulk raulk force-pushed the fix/compilation-err branch from 20d6373 to 88684c7 Compare May 12, 2020 12:31
@raulk raulk force-pushed the fix/compilation-err branch from 88684c7 to 630bd41 Compare May 12, 2020 12:50
@raulk raulk mentioned this pull request May 12, 2020
Closed
@raulk raulk merged commit d9d1851 into master May 12, 2020
@raulk raulk deleted the fix/compilation-err branch May 12, 2020 16:25
@raulk
Copy link
Member Author

raulk commented May 12, 2020

Tests fail because of the races that will be fixed in #907.

@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raulk @vyzo