Skip to content

various identify fixes and nits #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarshkshah1992 merged 12 commits into from
May 14, 2020
Merged

various identify fixes and nits #922

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5f1fb4f
refactor IDService and add peerloop
aarshkshah1992 Apr 30, 2020
c254773
second draft
aarshkshah1992 Apr 30, 2020
d9dde9b
better tests
aarshkshah1992 May 1, 2020
1583b08
fixed tests
aarshkshah1992 May 4, 2020
8f715ad
remove races
aarshkshah1992 May 4, 2020
a2bb2ff
fixed comment
aarshkshah1992 May 4, 2020
e85f5f2
remove broadcast
aarshkshah1992 May 4, 2020
226e7ec
backward compatible protocol
aarshkshah1992 May 4, 2020
1fddb7d
changes as per review
aarshkshah1992 May 7, 2020
a01d732
go fmt
aarshkshah1992 May 7, 2020
e1680c2
restart peer handler
aarshkshah1992 May 11, 2020
355fd08
various identify fixes and nits
Stebalien May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed comment
  • Loading branch information
@aarshkshah1992
aarshkshah1992 committed May 13, 2020
commit a2bb2ff0aeb06a1ff96c40f3e600ab9fc7c9a7d8
2 changes: 1 addition & 1 deletion p2p/protocol/identify/id_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func getSignedRecord(t *testing.T, h host.Host, p peer.ID) *record.Envelope {
// we're using BlankHost in our tests, which doesn't automatically generate peer records
// and emit address change events on the bus like BasicHost.
// This generates a record, puts it in the peerstore and emits an addr change event
// will cause the identify service to push it to all peer it's connected to.
// which will cause the identify service to push it to all peers it's connected to.
func emitAddrChangeEvt(t *testing.T, h host.Host) {
t.Helper()

Expand Down