Skip to content

feat: add support for specifying noise and secio #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacobheun wants to merge 3 commits into from
Closed

feat: add support for specifying noise and secio #32

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83ae5d4
feat: add support for specifying noise and secio
jacobheun Feb 9, 2020
20d9745
chore: revert changes to dht test files
jacobheun Feb 12, 2020
81c89c0
feat: pass daemon debug logs to stderr
jacobheun Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ class Daemon {
}

const daemon = execa(this._binPath, execOptions)
if (process.env.DEBUG) {
daemon.stderr.pipe(process.stderr)
Copy link
Member

@mpetrunic mpetrunic Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't library logs suppose to be in process.stdout?

Might be useful to pass custom env to execa, I think something like execa(this._binPath, execOptions, {env: {DEBUG: "libp2p:noise, libp2p:secio"}}) should be supported

Copy link
Contributor Author

@jacobheun jacobheun Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All debug logs are going to stderr as we're just using the defaults in the debug module atm.

execa forwards env to the new process, so it shouldn't be necessary as we only need forwarding right now. We don't need the conditional though.

}

daemon.stdout.once('data', () => {
resolve()
Expand Down