Skip to content

Support /dns/ (in addition to /dns4/ and /dns6/) in the websocket browser transport #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanb merged 2 commits into from
Jun 30, 2020
Merged

Support /dns/ (in addition to /dns4/ and /dns6/) in the websocket browser transport #1626

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de94ceb
Support /dns/ as well as /dns4/ and /dns6/ in the websocket wasm ext …
expenses Jun 24, 2020
ee96625
Merge branch 'master' into wasm-ext-dns
tomaka Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion transports/wasm-ext/src/websockets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const websocket_transport = () => {
/// Turns a string multiaddress into a WebSockets string URL.
// TODO: support dns addresses as well
const multiaddr_to_ws = (addr) => {
let parsed = addr.match(/^\/(ip4|ip6|dns4|dns6)\/(.*?)\/tcp\/(.*?)\/(ws|wss|x-parity-ws\/(.*)|x-parity-wss\/(.*))$/);
let parsed = addr.match(/^\/(ip4|ip6|dns4|dns6|dns)\/(.*?)\/tcp\/(.*?)\/(ws|wss|x-parity-ws\/(.*)|x-parity-wss\/(.*))$/);
if (parsed != null) {
let proto = 'wss';
if (parsed[4] == 'ws' || parsed[4] == 'x-parity-ws') {
Expand Down