[libp2p-kad] Remove the Discovered event.
#1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the discussion in libp2p#1628.
romanb
force-pushed
the
kad-remove-discovered
branch
from
41aa15a to
19f548d
Compare
mxinden
approved these changes
Jun 30, 2020
Member
|
@romanb can you add an entry to https://github.com/libp2p/rust-libp2p/blob/master/protocols/kad/CHANGELOG.md? |
Contributor
Author
|
I will do that as part of an upcoming release PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to (and thus branched off from) #1628 - see the discussion there. It probably shouldn't be rushed in order to give users a chance to voice their concerns here early, in case there are any.