protocols/plaintext: Do not UVI encode goodput #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only prefix handshake messages with the message length in bytes as an unsigned varint. Return a plain socket once handshaking succeeded.
romanb
approved these changes
Sep 17, 2020
Contributor
romanb
left a comment
romanb
left a comment
There was a problem hiding this comment.
👍 Hopefully the specs can be clarified. It is curious that this hasn't come up before. I was probably naively assuming compatibility was tested earlier in the context of #1236, or maybe the other implementation(s) actually changed afterwards?
Member
Author
I have opened libp2p/specs#295.
As far as I can tell from the initial pull request libp2p/go-libp2p-core#37 the Go implementation only UVI encoded the handshake messages . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only prefix handshake messages with the message length in bytes as an
unsigned varint. Return a plain socket once handshaking succeeded.
Tested compatibility with https://github.com/mxinden/libp2p-perf.
Fixes #1760