swarm/src/toggle: Ignore listen upgr errors when disabled #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A disabled `ToggleProtoHandler` can receive listen upgrade errors in the following two cases: 1. Protocol negotiation on an incoming stream failed with no protocol being agreed on. 2. When combining `ProtocolsHandler` implementations a single `ProtocolsHandler` might be notified of an inbound upgrade error unrelated to its own upgrade logic. For example when nesting a `ToggleProtoHandler` in a `ProtocolsHandlerSelect` the former might receive an inbound upgrade error even when disabled. `ToggleProtoHandler` should ignore the error in both of these cases.
Member
Author
|
In case this patch finds approval, I would like to relase |
romanb
approved these changes
Feb 4, 2021
Contributor
romanb
left a comment
romanb
left a comment
There was a problem hiding this comment.
👍 Feel free to cut releases after merging.
Member
Author
I planned to only publish a new |
Contributor
Not necessarily. I only used plural in case you think it would be desirable to have a |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A disabled
ToggleProtoHandlercan receive listen upgrade errors in thefollowing two cases:
Protocol negotiation on an incoming stream failed with no protocol being
agreed on.
When combining
ProtocolsHandlerimplementations a singleProtocolsHandlermight be notified of an inbound upgrade error unrelated to its own upgrade
logic. For example when nesting a
ToggleProtoHandlerin aProtocolsHandlerSelectthe former might receive an inbound upgrade erroreven when disabled.
ToggleProtoHandlershould ignore the error in both of these cases.Fixes paritytech/polkadot#2373.