Add BoxedMuxed transport #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
force-pushed
the
boxed-transport
branch
2 times, most recently
from
dcb2354 to
ebdcffb
Compare
tomaka
force-pushed
the
boxed-transport
branch
from
ebdcffb to
d23afca
Compare
tomaka
force-pushed
the
boxed-transport
branch
from
d23afca to
bf6592a
Compare
Member
Author
|
The test failure doesn't really make sense. |
twittner
reviewed
Sep 6, 2018
| fn listen_on(&self, addr: Multiaddr) -> Result<(Listener<O>, Multiaddr), Multiaddr>; | ||
| fn dial(&self, addr: Multiaddr) -> Result<Dial<O>, Multiaddr>; | ||
| fn nat_traversal(&self, server: &Multiaddr, observed: &Multiaddr) -> Option<Multiaddr>; | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need this trait?
Member
Author
There was a problem hiding this comment.
It's the same as Transport, but since it doesn't have associated types and doesn't take by ownership, it can be put in a Box.
twittner
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #458
Adds an abstract implementation of
MuxedTransport, so that we can put a transport in a Box-like structure.