Skip to content

refactor(kad): use oneshots and async-await for outbound streams #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 11 commits into from
Nov 22, 2023
Merged

refactor(kad): use oneshots and async-await for outbound streams #4901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c996b3
Pass on `QueryId` for `AddProvider`
thomaseizinger Nov 20, 2023
00e624b
Convert tuple variants to structs
thomaseizinger Nov 20, 2023
b804bc8
Track `has_answer` separately
thomaseizinger Nov 20, 2023
5101e63
Always track `QueryId`
thomaseizinger Nov 20, 2023
4b17fcc
Refactor kademlia to use `async-await`
thomaseizinger Nov 20, 2023
75ff7a6
Close stream after sending
thomaseizinger Nov 20, 2023
51556d6
Update protocols/kad/src/handler.rs
thomaseizinger Nov 20, 2023
0cd4f95
Rename fn
thomaseizinger Nov 21, 2023
7891ab1
Merge remote-tracking branch 'origin/refactor/kad-use-oneshots' into …
thomaseizinger Nov 21, 2023
43d2e6d
Don't double count streams
thomaseizinger Nov 22, 2023
ba24970
Merge branch 'master' into refactor/kad-use-oneshots
thomaseizinger Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions protocols/kad/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ asynchronous-codec = { workspace = true }
futures = "0.3.29"
libp2p-core = { workspace = true }
libp2p-swarm = { workspace = true }
futures-bounded = { workspace = true }
quick-protobuf = "0.8"
quick-protobuf-codec = { workspace = true }
libp2p-identity = { workspace = true, features = ["rand"] }
Expand Down
1 change: 1 addition & 0 deletions protocols/kad/src/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3173,6 +3173,7 @@ impl QueryInfo {
multiaddrs: external_addresses.clone(),
connection_ty: crate::protocol::ConnectionType::Connected,
},
query_id,
},
},
QueryInfo::GetRecord { key, .. } => HandlerIn::GetRecord {
Expand Down
Loading