Fix error handling in Swarm dial() and listen_on() #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
force-pushed
the
fix-err-transport
branch
from
df5585e to
7aee015
Compare
Member
Author
|
Rebased over master ; travis tests won't pass because of #61 |
tomaka
force-pushed
the
fix-err-transport
branch
from
7aee015 to
ff2fe98
Compare
eira-fransham
suggested changes
Dec 7, 2017
| let negotiated = multistream_select::listener_select_proto(connection, iter); | ||
| negotiated.map(move |(upgrade_id, conn)| (upgrade_id, conn, upgrade, client_addr)) | ||
| .map_err(|_| panic!()) // TODO: | ||
| .map_err(|err| IoError::new(IoErrorKind::Other, err)) |
Contributor
There was a problem hiding this comment.
Style nit: I prefer use std::io; to use std::io::Error as IoError;, but that could be argued as personal taste.
| } | ||
|
|
||
| fn cause(&self) -> Option<&error::Error> { | ||
| match *self { |
Contributor
There was a problem hiding this comment.
Style nit: maybe use an if let?
Member
Author
There was a problem hiding this comment.
Nit: A match is better if we add more variants in the future
|
|
||
| fn cause(&self) -> Option<&error::Error> { | ||
| match *self { | ||
| MultistreamSelectError::IoError(ref err) => { |
Contributor
There was a problem hiding this comment.
Why do we repeat Error/MultistreamSelect twice in this? Can it be enum Error { Io(...), ... }? We know we're in the multistream select crate already.
eira-fransham
approved these changes
Dec 7, 2017
tomaka
force-pushed
the
fix-err-transport
branch
from
ff2fe98 to
809ff7e
Compare
mxinden
pushed a commit
to mxinden/rust-libp2p
that referenced
this pull request
Nov 20, 2020
dkuehr
pushed a commit
to openmina/rust-libp2p
that referenced
this pull request
Oct 24, 2023
…lidation for received staged ledger parts re: libp2p#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.