Improve the API of the secio crate #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eira-fransham
approved these changes
Dec 7, 2017
Contributor
eira-fransham
left a comment
eira-fransham
left a comment
There was a problem hiding this comment.
Code looks good, some questions about docs.
libp2p-secio/src/lib.rs
Outdated
| /// Loading the keys: | ||
| /// | ||
| /// ```ignore | ||
| /// ley key_pair = SecioKeyPair::rsa_from_pkcs8(include_bytes!("private.pk8"), |
Contributor
There was a problem hiding this comment.
Typo: this should say let
libp2p-secio/src/lib.rs
Outdated
| mod handshake; | ||
| mod structs_proto; | ||
|
|
||
| /// Implementation of the `ConnectionUpgrade` trait of `libp2p_swarm`. Automatically applies any |
Contributor
There was a problem hiding this comment.
Should this say "any secio on any connection"?
mxinden
pushed a commit
to mxinden/rust-libp2p
that referenced
this pull request
Nov 20, 2020
* Clean up code * Upgrade crates * Update example to use signing * Add debug log * Improve keepalive for peers without gossipsub support * Improve debug logs for new peer types
dkuehr
pushed a commit
to openmina/rust-libp2p
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ringcrate is no longer exposed at all in the API.