Add a VarintCodec type #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eira-fransham
suggested changes
Jan 15, 2018
Contributor
eira-fransham
left a comment
eira-fransham
left a comment
There was a problem hiding this comment.
Just a typo and a possibly-inaccurate TODO
varint-rs/src/lib.rs
Outdated
| } | ||
| }, | ||
| VarintCodecInner::Poisonned => { | ||
| panic!("Poisonned decoder") |
Contributor
There was a problem hiding this comment.
Typo, and maybe "Varint codec was poisoned" would be more descriptive.
| type Error = io::Error; | ||
|
|
||
| fn encode(&mut self, item: D, dst: &mut BytesMut) -> Result<(), io::Error> { | ||
| let encoded_len = encode(item.as_ref().len()); // TODO: can be optimized by not allocating? |
Member
Author
There was a problem hiding this comment.
encode returns a Vec<u8>, while we could directly write the length to dst.
eira-fransham
approved these changes
Jan 15, 2018
dkuehr
pushed a commit
to openmina/rust-libp2p
that referenced
this pull request
Oct 24, 2023
Ask `get_some_initial_peers` RPC and choose peers from the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.